mirrors/krata
1
0
Fork 0
mirror of https://github.com/edera-dev/krata.git synced 2025-08-03 05:10:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

network: recalculate TCP checksums on IPv4 in vbridge

Browse Source
This commit is contained in:
Alex Zenla 2024-02-12 20:57:17 +00:00
parent d595f1639a
commit 494e7f6851
No known key found for this signature in database
GPG Key ID: 067B238899B51269
1 changed files with 24 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
network/src/vbridge.rs
View File

@ -1,6 +1,6 @@
use anyhow::{anyhow, Result}; use anyhow::{anyhow, Result};
use bytes::BytesMut; use bytes::BytesMut;
use etherparse::Ethernet2Header; use etherparse::{EtherType, Ethernet2Header, IpNumber, Ipv4Header, TcpHeader};
use log::{debug, trace, warn}; use log::{debug, trace, warn};
use smoltcp::wire::EthernetAddress; use smoltcp::wire::EthernetAddress;
use std::{ use std::{
@ -121,26 +121,45 @@ impl VirtualBridge {
match selection { match selection {
VirtualBridgeSelect::PacketReceived(Some(packet)) => { VirtualBridgeSelect::PacketReceived(Some(packet)) => {
let header = match Ethernet2Header::from_slice(&packet) { let mut packet: Vec<u8> = packet.into();
Ok((header, _)) => header, let (header, payload) = match Ethernet2Header::from_slice(&packet) {
Ok(data) => data,
Err(error) => { Err(error) => {
debug!("virtual bridge failed to parse ethernet header: {}", error); debug!("virtual bridge failed to parse ethernet header: {}", error);
continue; continue;
} }
}; };
if header.ether_type == EtherType::IPV4 {
let (ipv4, payload) = Ipv4Header::from_slice(payload)?;
// recalculate TCP checksums when routing packets.
// the xen network backend / frontend drivers for linux
// are very stupid and do not calculate these properly
// despite all best attempts as making it do so.
if ipv4.protocol == IpNumber::TCP {
let (mut tcp, payload) = TcpHeader::from_slice(payload)?;
tcp.checksum = tcp.calc_checksum_ipv4(&ipv4, payload)?;
let tcp_header_offset = Ethernet2Header::LEN + ipv4.header_len();
let tcp_header_bytes = tcp.to_bytes();
for (i, b) in tcp_header_bytes.iter().enumerate() {
packet[tcp_header_offset + i] = *b;
}
}
}
let destination = &header.destination; let destination = &header.destination;
if destination == BROADCAST_MAC_ADDR { if destination == BROADCAST_MAC_ADDR {
trace!( trace!(
"broadcasting bridged packet from {}", "broadcasting bridged packet from {}",
EthernetAddress(header.source) EthernetAddress(header.source)
); );
broadcast_rx_sender.send(packet)?; broadcast_rx_sender.send(packet.as_slice().into())?;
continue; continue;
} }
match members.lock().await.get(destination) { match members.lock().await.get(destination) {
Some(member) => { Some(member) => {
member.bridge_rx_sender.try_send(packet)?; member.bridge_rx_sender.try_send(packet.as_slice().into())?;
trace!( trace!(
"sending bridged packet from {} to {}", "sending bridged packet from {} to {}",
EthernetAddress(header.source), EthernetAddress(header.source),