strips/pork
2
0
Fork 0
mirror of https://github.com/GayPizzaSpecifications/pork.git synced 2025-08-03 13:11:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

ast: fix codegen of equals to not produce warnings

Browse Source
This commit is contained in:
Alex Zenla
2023-09-23 15:53:54 -07:00
parent c340cfb86d
commit a292449b6a
5 changed files with 23 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
buildext/src/main/kotlin/gay/pizza/pork/buildext/ast/AstStandardCodegen.kt
View File

@ -421,9 +421,10 @@ class AstStandardCodegen(pkg: String, outputDirectory: Path, world: AstWorld) :
visitSelfFunction.body.add("visitor.visit${type.name}(this)")
kotlinClassLike.functions.add(visitSelfFunction)
val equalsAndHashCodeMembers = kotlinClassLike.members.map {
val hashCodeMembers = kotlinClassLike.members.map {
it.name
}.sortedBy { it == "type" }
val equalsMembers = hashCodeMembers.filterNot { it == "type" }
val equalsFunction = KotlinFunction(
"equals",
returnType = "Boolean",
@ -433,14 +434,19 @@ class AstStandardCodegen(pkg: String, outputDirectory: Path, world: AstWorld) :
"other",
"Any?"
))
equalsFunction.body.add("if (other !is ${type.name}) return false")
var predicate = equalsAndHashCodeMembers.mapNotNull {
if (it == "type") null else "other.${it} == $it"
}.joinToString(" && ")
if (predicate.isEmpty()) {
predicate = "true"
if (equalsMembers.isNotEmpty()) {
equalsFunction.body.add("if (other !is ${type.name}) return false")
var predicate = equalsMembers.joinToString(" && ") {
"other.${it} == $it"
}
if (predicate.isEmpty()) {
predicate = "true"
}
equalsFunction.body.add("return $predicate")
} else {
equalsFunction.isImmediateExpression = true
equalsFunction.body.add("other is ${type.name}")
}
equalsFunction.body.add("return $predicate")
kotlinClassLike.functions.add(equalsFunction)
val hashCodeFunction = KotlinFunction(
@ -449,12 +455,12 @@ class AstStandardCodegen(pkg: String, outputDirectory: Path, world: AstWorld) :
overridden = true
)
if (equalsAndHashCodeMembers.size == 1) {
val member = equalsAndHashCodeMembers.single()
if (hashCodeMembers.size == 1) {
val member = hashCodeMembers.single()
hashCodeFunction.isImmediateExpression = true
hashCodeFunction.body.add("31 * ${member}.hashCode()")
} else {
for ((index, value) in equalsAndHashCodeMembers.withIndex()) {
for ((index, value) in hashCodeMembers.withIndex()) {
if (index == 0) {
hashCodeFunction.body.add("var result = ${value}.hashCode()")
} else {